Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast level loaded event on tech. #11

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Broadcast level loaded event on tech. #11

merged 1 commit into from
Nov 22, 2016

Conversation

boushley
Copy link
Contributor

This allows consumers to get at custom metadata from the HLS manifest.

@shacharz
Copy link
Member

Seems reasonable, let's make it more general:

Object.keys(Hls.Events).forEach(function(key) {
  var eventName = Hls.Events[key];
  hls.on(eventName, function(event, data) {
    tech.trigger(eventName, data);
  });
});

@boushley
Broadcast level loaded event on tech.
6d4ed21 
This allows consumers to get at custom metadata from the HLS manifest.
@boushley
Copy link
Contributor Author

Good point. I've gone ahead and updated this to broadcast all events.

@shacharz shacharz merged commit a26a627 into Peer5:master Nov 22, 2016
@boushley boushley deleted the broadcast-level-details branch November 22, 2016 15:48
@shacharz shacharz mentioned this pull request Nov 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@boushley boushley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boushley @shacharz