Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deps, switch to webpack #22

Merged
merged 3 commits into from
May 1, 2017
Merged

remove deps, switch to webpack #22

merged 3 commits into from
May 1, 2017

Conversation

mrbar42
Copy link
Collaborator

@mrbar42 mrbar42 commented Apr 26, 2017 •
edited
Loading

  • switch to webpack 2
  • single umd bundle
  • checkout latest minified bundle
  • video.js is now peer dependency
  • remove contrib-media-source contrib-hls
  • updated examples
  • add editorconfig
  • new major

shacharz
shacharz requested changes Apr 30, 2017
View reviewed changes
webpack.config.js Outdated
filename: 'videojs-contrib-hlsjs.min.js'
},
externals: [{
'video\.js': 'commonjs video.js'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to object with global, commonjs

@mrbar42 mrbar42 requested a review from shacharz May 1, 2017 11:11
@shacharz shacharz merged commit 1ca2fc1 into master May 1, 2017
@shacharz shacharz deleted the bundle-facelift branch May 1, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shacharz shacharz shacharz approved these changes

Assignees

@shacharz shacharz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrbar42 @shacharz