Added video.js v6 support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbar42
requested changes
Aug 28, 2017
src/videojs.hlsjs.js
Outdated
| if (videojs) { | ||
| videojs.getComponent('Html5').registerSourceHandler(HlsSourceHandler, 0); | ||
| videojs.getTech('Html5').registerSourceHandler(HlsSourceHandler, 0); |
There was a problem hiding this comment.
lets fallback to getComponent since its needed for older versions of videojs5
var html5Tech = videojs.getTech && videojs.getTech('Html5'); // videojs6 (partially on videojs5 too)
html5Tech = html5Tech || (videojs.getComponent && videojs.getComponent('Html5')); // videojs5
if (html5Tech) {
html5Tech.registerSourceHandler(HlsSourceHandler, 0);
}
src/videojs.hlsjs.js
Outdated
| @@ -150,8 +150,12 @@ var HlsSourceHandler = { | |||
| if (Hls.isSupported()) { | |||
| var videojs = require('video.js'); // resolved UMD-wise through webpack | |||
|
|
|||
| // we could just use `import videojs from 'video.js'` | |||
There was a problem hiding this comment.
its great that we'll support es6 modules, but the comment is not necessary
it can be // support es6 style import
mrbar42
approved these changes
Aug 29, 2017
|
publish as v3.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.